DLBFoam: An open-source dynamic load balancing model for fast reacting flow simulations in OpenFOAM. https://doi.org/10.1016/j.cpc.2021.108073, https://doi.org/10.1063/5.0077437
GNU General Public License v3.0
76
stars
27
forks
source link
non-existing chemical time scale function in pyjac model #29
The function tc() that calculates the chemical time scale in chemistryModel uses the reaction coefficients from the stock chemistry solver to calculate a chemical time scale. This chemical time scale is then could be used in combustionModel for various TCI models, such as PaSR. Currently this function is not implemented in loadBalancedChemistryModel_pyJac, which leads to a flawed setup if a user uses a TCI model with pyJac setup. Until this feature is implemented, I suggest it is overridden as notImplemented in the model following legacy pyjac model, so the user will see an error message when they try this combination.
blttkgl
commented
2 years ago
Hey,
The function tc() that calculates the chemical time scale in chemistryModel uses the reaction coefficients from the stock chemistry solver to calculate a chemical time scale. This chemical time scale is then could be used in combustionModel for various TCI models, such as PaSR. Currently this function is not implemented in loadBalancedChemistryModel_pyJac, which leads to a flawed setup if a user uses a TCI model with pyJac setup. Until this feature is implemented, I suggest it is overridden as notImplemented in the model following legacy pyjac model, so the user will see an error message when they try this combination.