Firoozh/bug and clean - Githubissues

AaltoRSE / speech2text

Instructions to setup and use Aalto speech2text app on Triton.

Other

1 stars 1 forks source link

Firoozh/bug and clean #11

Closed hsnfirooz closed 7 months ago

hsnfirooz commented 7 months ago

Fixing open issues:

Issue #4 in commit 35a018edc1566772710d7fd86bcd9ac569e1bc87
Issue #6 in commit 7626fd08a476d43260dbdea356c0456decb4d884
Issue #7 in commit 6b6d4530eaad9e785beefabfaa9f04f036d5ace8
Issue #10 in commit 382b77911c018ee102dbf37ff8a882c7bc5cb0bf

In addition, added support for the following:

Checking a valid aalto email
Better logging for GPU hardware failure
Better error logging as WhisperX was complaining for the language setting

ruokolt commented 7 months ago

Looks good!

I suggested a modification to subprocess.run exception handling: catch subprocess.CalledProcessError instead of Exception (but backoff to Exception anyways).

Also ran linting (black + isort).