search

AamuLumi / Rimworld-Diary

Rimworld mod to write, read and export colony's tales.
MIT License
7 stars 0 forks source link

Error when exporting HTML with Progress Renderer #16

Closed AnnLikki closed 1 year ago

AnnLikki commented 1 year ago

I am not sure if I am supposed to submit my issue here or elsewhere. I for some reason can't export an html file with pictures, it causes an error: image Here's PR's folder on the desktop: image Here's mod settings: image Here's what export generates (a proper html file, but pictures aren't there, seems like they do not export together with the file, no "img-0" etc in the vicinity of the html file): image

AnnLikki commented 1 year ago

Please let me know if I need to provide more feedback on the issue!

AamuLumi commented 1 year ago

Hey,

Normally, Diary keeps paths of generated images by ProgressRenderer, and use these paths to create copy of these images in the HTML export. Did you move manually images or did you change the export path in ProgressRenderer ?

Thanks a lot :)

AnnLikki commented 1 year ago

Hey,

Normally, Diary keeps paths of generated images by ProgressRenderer, and use these paths to create copy of these images in the HTML export. Did you move manually images or did you change the export path in ProgressRenderer ?

Thanks a lot :)

I use desktop folder as directory for PR (I believe it was a default setting) image

Also if it helps images in the Diary are showing correctly image

AamuLumi commented 1 year ago

Okay that's pretty strange. I'll do some tests tomorrow to reproduce this behaviour.

Thanks for all these informations !

AamuLumi commented 1 year ago

Hey !

I did some tests with a similar configuration, and I was not able to reproduce the bug. Diary shows images correctly, so this is not a problem of generated images paths not stored correctly. HTML file is generated but export crashes, so I'm sure it's crashing when copying images to the exported folder.

I have to ask a stupid question : do you have enough space on your storage where you storing your exports ? PR's images are pretty big, so I think it's a possibility.

If it's not that, you can enable the Rimworld dev mode in Settings > General > Development mode, and give me the content of your debug log after trying to export.

AnnLikki commented 1 year ago

do you have enough space on your storage where you storing your exports ?

Yes, in fact, I do. PR's folder weights around 3-4 GB, and I have extra 60+ GB on the D disk, where I want to have my export (C disk has around 200 GB of free space). Also, previously I tried exporting the diary next or in the same directory as PR (in desktop folders), no luck.

If it's not that, give me the content of your debug log after trying to export.

Here you go: image

System.IO.FileNotFoundException: C:\Users\likki\Desktop\manually\rimworld-jennifer-33185-5500-2-06-14.jpg does not exist File name: 'C:\Users\likki\Desktop\manually\rimworld-jennifer-33185-5500-2-06-14.jpg'

Ohhh I see. It searches for manually taken pics, which I moved from "manual" to general since I wanted to scroll thru them together. Should I fix it manually (checking every error-causing file) or there's a better solution? I can find manual files by looking for those that have different two last digits that indicate time of picture taken.

AnnLikki commented 1 year ago

But anyway there's a problem, could you help me figure out what's going on? image image

AamuLumi commented 1 year ago

I don't have prepared solution in Diary for this kind of problem, so yeah, you have to move back the screenshots to their origin. If you see another problem after moving back the screenshots, don't hesitate to reopen the issue.

And with this problem fixed, I'll release the 1.1.3 version in the next hour. :)

AamuLumi commented 1 year ago

But anyway there's a problem, could you help me figure out what's going on? image image

It seems the original path was ...\Desktop\manually\... and not ...\Desktop\jennifer\manually\....

AnnLikki commented 1 year ago

Ohhh. Maybe that. Because I mid-game changed settings of PR to have a subfolder so it doesn't trash my entire desktop... Now there's no way to update Diary's paths?

AamuLumi commented 1 year ago

Currently, no. But I'll add a new feature to fix this (#18). I'll add this to the new version, so the new version will not be released now.

AnnLikki commented 1 year ago

I moved it and everything works. Thanks for helping me out! image image

AamuLumi commented 1 year ago

Okay I'm changing my plan again.

I'll release a new version with your 3 fixes, and I'll add a configuration window in the next small update (don't have the time to do the feature that today).