Aang23 / UndergroundBiomesConstructs

Underground Biomes Constructs for Minecraft 1.12.2 / 1.13.2
Other
12 stars 15 forks source link

[BUG] Stone wall particles missing #233

Open democat3457 opened 4 years ago

democat3457 commented 4 years ago

Breaking any UB stone wall variant gives untextured particles. MC version: 1.12.2 UB version: 1.3.8 See https://github.com/CalaMariGold/Rebirth-Of-The-Night/issues/273

democat3457 commented 4 years ago

image

Foreck1 commented 4 years ago

Since this can seemingly not be fixed through conventional resourcepack methods due to the location of the models, if I'm not mistaken, wouldn't changing wall to all fix the particles? https://github.com/Aang23/UndergroundBiomesConstructs/blob/6c67a8427326882952a1fd4d808e222b8ef993d4/src/main/resources_templates/assets/undergroundbiomes/blockstates/wall.json#L42

LemADEC commented 2 years ago

The underlying vanilla block model already replaces the particle texture with the one passed for the wall. The issue comes from the default entry which doesn't work well with variants. It's fixed in the next update.