search

Aanok / jftui

Jellyfin Terminal User Interface
The Unlicense
149 stars 7 forks source link

Fill mpv filename property with the real file name #45

Open Estebiu opened 1 month ago

Estebiu commented 1 month ago

jftui version jftui 0.7.2, libmpv 2.3, libcurl 8.10.1 OpenSSL/3.3.2, yajl 20100

Describe the bug The filename reported to mpv doesn't match the filename the jellyfin server reports; instead it's just "stream?static=true&mediasourceid=xxxxxxxxx;"

To Reproduce Play whatever media.

Expected behavior I expect the filename to be the one that jellyfin reports. The issue I personally have is that when I try to make a screenshot, the later's filename is something like: stream?static=true&mediasourceid=xxxxxxxx;|5:07|2024-10-09|11:18:17.jpg

When screenshotting the video while playing the file directly with mpv the filename of the screenshot is: The.Nice.Guys.2016.Vostfr.2160p.WEBRip.DDP5.1.x264-GalaxyRG|56:58|2024-10-09|11:21:20.jpg'

I know this is probably a very small problem for the majority of people; but personally, as someone who loves to screenshot/cut parts of videos, this is a dealbreaker.

Aanok commented 1 month ago

jftui sets the title property of its playback items (which you see displayed in the bottom left of the OSD), so you can try replacing %filename in your screenshot-template option to %{media-title} and you should already get something close to what you're looking for.

This aside though, I think your suggestion is still sensible both for your specific use case and to get a more meaningful File displayed in the stats you get pressing i or I :+1:

Estebiu commented 1 month ago

Thanks! Don't know why I didn't try to find another way. Silly me. Feel free to close this issue.