Closed MartinBernstorff closed 5 months ago
Looks like some formatting rules failed.
✨ The action has attempted automatic fixes ✨
If any were succesful, they were committed to the branch.
We suggest using git pull --rebase
to apply them locally.
If some errors could not be fixed automatically, you can:
🏎️ Get results locally by running pre-commit run --all-files
🕵️ Examine the results in the Run pre-commit
section of this workflow pre-commit
We also strongly recommend setting up the ruff
and black
extensions to auto-format on save in your chosen editor.
Comparing mbern_update_dependencies
(469480c) with main
(8881d7b)
⁉️ 7 (👁 7)
dropped benchmarks
Benchmark | main |
mbern_update_dependencies |
Change | |
---|---|---|---|---|
👁 | test_bench[aggregations=['max', 'mean']] |
547.5 ms | N/A | N/A |
👁 | test_bench[n_features=2.0x] |
729.1 ms | N/A | N/A |
👁 | test_bench[n_lookbehinds=2.0x] |
727 ms | N/A | N/A |
👁 | test_bench[n_lookbehinds=4.0x] |
1.1 s | N/A | N/A |
👁 | test_bench[n_lookbehinds=8.0x] |
1.9 s | N/A | N/A |
👁 | test_bench[n_pred_times=2.0x] |
1 s | N/A | N/A |
👁 | test_bench[x] |
539.9 ms | N/A | N/A |
Turns out the error was because of a change I made to
iterpy
. For those interested, when I calledflatten
, it flattens if the object is iterable. A dataframe is iterable, and if flattened, it returns a sequence of series. That meant we called dataframe methods on sequences of series, which obviously does not work.Sorry about that @sarakolding! Good thing you asked, and only fair I fix it.
To get your PR up to date, rebuild the environment.
I have pinned the
iterpy
version in this project so it never changes and we do not get similar errors in the future.