Aarhus-Psychiatry-Research / timeseriesflattener

Converting irregularly spaced time series, such as eletronic health records, into dataframes for tabular classification.
https://Aarhus-Psychiatry-Research.github.io/timeseriesflattener
MIT License
18 stars 2 forks source link

fix sliding window test #552

Closed sarakolding closed 4 months ago

sarakolding commented 4 months ago

had forgotten to add step_size arg to step_size test and only realised as I merged with main 🙃

found that

  1. still need that magical +2 instead of +1
  2. "max" takes the highest number, so with lookbehinds it takes the shortest one (because they are minus) - added abs
codspeed-hq[bot] commented 4 months ago

CodSpeed Performance Report

Merging #552 will not alter performance

Comparing 422-perf-sliding-window (9d12f45) with main (5ba3b68)

Summary

✅ 7 untouched benchmarks