search

Aarhus-Psychiatry-Research / timeseriesflattener

Converting irregularly spaced time series, such as eletronic health records, into dataframes for tabular classification.
https://Aarhus-Psychiatry-Research.github.io/timeseriesflattener
MIT License
18 stars 2 forks source link

bug(#559): using step_size with multiple features leads to misaligned join #560

Closed HLasse closed 3 months ago

HLasse commented 4 months ago

Predictions times are now sorted before being processed ensuring that features are generated in the same order for specs using step_size and those not.

Merged as features made with step_size != None does not work as expected without this.

bug(#559): using step_size with multiple features leads to misaligned join

Fixes #559

fix: scrambled features with step size

HLasse commented 4 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HLasse and the rest of your teammates on Graphite Graphite

codspeed-hq[bot] commented 4 months ago

CodSpeed Performance Report

Merging #560 will not alter performance

Comparing bug/559/using_step_size_with_multiple_features_leads_to_misaligned_join (6bdddbd) with main (e3b4bbd)

Summary

✅ 7 untouched benchmarks