search

Aarhus-Psychiatry-Research / timeseriesflattener

Converting irregularly spaced time series, such as eletronic health records, into dataframes for tabular classification.
https://Aarhus-Psychiatry-Research.github.io/timeseriesflattener
MIT License
18 stars 2 forks source link

fix(#514): simplify public-facing types by inlining type-aliases #564

Closed HLasse closed 3 months ago

HLasse commented 3 months ago

fix(#514): simplify public-facing types by inlining type-aliases

Fixes #514

refactor: inline LookDistance and LookDistances

refactor: inline ValueType

refactor: inline default entity_id_col_name

refactor: inline default_prediction_time_uuid_col_name

refactor: inline default_pred_time_col_name

refactor: inline default_timestamp_col_name

refactor: inline InitDF_T

lint

HLasse commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HLasse and the rest of your teammates on Graphite Graphite

codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #564 will not alter performance

Comparing fix/514/simplify_public-facing_types_by_inlining_type-aliases (22c3ce6) with fix/514/simplify_public-facing_types_by_inlining_type-aliases (cdebaa7)

Summary

✅ 7 untouched benchmarks

github-actions[bot] commented 3 months ago

This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days.

github-actions[bot] commented 3 months ago

This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days.

github-actions[bot] commented 3 months ago

This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days.

MartinBernstorff commented 3 months ago

@HLasse Ready to make a decision here? 😉

HLasse commented 3 months ago

On the list for today 👍

github-actions[bot] commented 3 months ago

This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days.