search

Aarize29 / TextToSpeech

https://text-to-speech-app-lyart.vercel.app/
3 stars 1 forks source link

Enable Darkmode #1

Open Aarize29 opened 1 year ago

Aarize29 commented 1 year ago

Darkmode icon is given in the navbar, just add Darkmode functionality

lucAsC87 commented 1 year ago

I would like to work on this issue. :)

Aarize29 commented 1 year ago

Sure ,Go ahead 🔥

lucAsC87 commented 1 year ago

Thanks! ;)

Aarize29 commented 1 year ago

Are you working on this issue?

lucAsC87 commented 1 year ago

I still haven't got the time, sorry. If it's urgent, feel free to remove me from the assignment.

Aarize29 commented 1 year ago

I still haven't got the time, sorry. If it's urgent, feel free to remove me from the assignment.

No no, take your time

lucAsC87 commented 1 year ago

Hi Aarize, sorry to bother you, but (probably because I've never worked with vite) I'm unable to launch the project on Live Server. Any steps I'm missing?

Aarize29 commented 1 year ago

See first you need to have Nodejs installed on your system After that clone this project into your system, open the project in IDE like VS Code Go to the terminal and write :- npm install

After that use command :- npm run dev These commands help you to run the project locally

Aarize29 commented 1 year ago

Like in normal react app you use npm run start But to run a vite-react app you need to use npm run dev

lucAsC87 commented 1 year ago

Ok, node was already installed but there was some kind of issue that I've solved it by running npm install --force. Now everything seems to work correctly! :)

theavitw commented 1 year ago

Hey, I just made a pull request to solving this issue please assign me as contributor so that I can give it more to you. I just made one component of dark mode nd use it in navbar. plz. run it in your local machine if online giving some error and set css by yourself.

lucAsC87 commented 1 year ago

Actually, I've already implemented all the dark mode. Maybe this issue could be closed. :sweat_smile:

Aarize29 commented 1 year ago

Hey hii @theavitw and @lucAsC87 Lucas has already fixed the issue and I merged his code Thanks lucas for your contribution

But Since It's an open source project, I would like to give @theavitw also the opportunity I merging his code

Aarize29 commented 1 year ago

To be honest, I already know how to enable dark mode, but I created this issue just to interact with people Thank you guys for your contribution.

lucAsC87 commented 1 year ago

No problem, it was my 2nd open source contribution and it was great practice. :smile: