AaronC81 / sord

Convert YARD docs to Sorbet RBI and Ruby 3/Steep RBS files
https://sord.aaronc.cc
MIT License
304 stars 18 forks source link

Follow overridden methods to determine tags #156

Closed dorner closed 2 years ago

dorner commented 2 years ago

Currently, sord only looks at tags on the method that it's currently parsing. However, YARD is smart enough to be able to determine when a class is overriding a method. Often, the base method will be documented but the subclasses won't need to do that, resulting in sord complaining that the subclassed method has no documentation.

This PR follows YARD's overridden_method to check to see if tags exist on the original method if they don't on the current one.

AaronC81 commented 2 years ago

This is awesome! Cheers