search

AaronC81 / sord

Convert YARD docs to Sorbet RBI and Ruby 3/Steep RBS files
https://sord.aaronc.cc
MIT License
299 stars 18 forks source link

Fix `undefined method 'exists?' for File:Class` #165

Closed matmorel closed 1 year ago

matmorel commented 1 year ago

Hello,

This PR fixes #164 while keeping compatibility with ruby 2.x Please let me know if any changes are needed.

Thanks

AaronC81 commented 1 year ago

Thanks for the PR! It's a neat approach, but I think it can be a lot simpler - File.exist? has existed alongside the now-removed exists? for a long time in Ruby 2, so I'm happy for the exists? to just be swapped with exist?.

If you'd like to update your PR to do this, then go ahead - but if not them I'm happy to make this quick change too!

matmorel commented 1 year ago

Oh I didn't know that, updated

AaronC81 commented 1 year ago

Thanks! Don't know what's going on with the CI... after work I'll try to fix that, get this merged, and put out a release 👍

AaronC81 commented 1 year ago

Managed to completely screw up the rebase for this, but I have merged your PR on the command-line, and it is in master now! I'll do a release shortly

AaronC81 commented 1 year ago

@matmorel 5.0.1 released, which contains this :)