search

AaronCCWong / react-card-flip

React component for card flipping animation.
https://aaronccwong.github.io/react-card-flip
MIT License
342 stars 64 forks source link

Large bundle because of dependencies #45

Closed Paso closed 5 years ago

Paso commented 5 years ago

The minified bundle is 14kB while the raw source is only 4kB, this is probably because some dependencies are included in the bundle. It should be up to the user of the package to install the required dependencies so that they are not duplicated in the requiring application. To resolve this the package.json should switch to peerDependencies instead of dependencies.

AaronCCWong commented 5 years ago

Agreed. I'll accept a PR from you or I can make the update later this week or early next week.

Paso commented 5 years ago

Awesome! Thank you!