search

AaronCCWong / react-card-flip

React component for card flipping animation.
https://aaronccwong.github.io/react-card-flip
MIT License
343 stars 64 forks source link

Use prop-types package #8

Closed wilomgfx closed 7 years ago

wilomgfx commented 7 years ago

React.PropTypes is deprecated as of React v15.5.

use https://www.npmjs.com/package/prop-types

to avoid errors like this

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

lotusms commented 7 years ago

Yes, I'm having the same issue. Looking into it. This has something to offer https://facebook.github.io/react/warnings/dont-call-proptypes.html

Just not sure how ...rest will go into play here. It'd be nice to have the code modified to fix this warning.

wilomgfx commented 7 years ago

I'll send a PR with the changes this weekend.

lotusms commented 7 years ago

+1

AaronCCWong commented 7 years ago

Sounds good. I will CR asap.