AaronDavidNewman / Smoosic

A music notation editor written in javascript
Other
98 stars 14 forks source link

new tools #16

Open odaymusic opened 4 years ago

odaymusic commented 4 years ago

Is it possible to develop the program to support eastern Arab voices ... where there are signs and keys for oriental music, if added, it will be something special

AaronDavidNewman commented 4 years ago

Is this what you mean? https://github.com/0xfe/vexflow/wiki/Microtonal-Support Vexflow is the engraving and font logic behind smoosic, so these are all planned. I admit to not knowing much about non-European music notation, but it is something I'd like to pursue.

AaronDavidNewman commented 4 years ago

@odaymusic I have added support to smoosic, for those 'microtone' accidentals that are supported by vex. I'm sure I got the playback wrong for some of them. I'd like to hear what you think.

odaymusic commented 4 years ago

Is this what you mean? https://github.com/0xfe/vexflow/wiki/Microtonal-Support Vexflow is the engraving and font logic behind smoosic, so these are all planned. I admit to not knowing much about non-European music notation, but it is something I'd like to pursue.

ys this i see new update for oriantal Symbols good work <3

odaymusic commented 4 years ago

Symbols are placed and you try this is very good, but you should also be affected by signs and symbols, since after adding the symbol, the sound has not changed .. For example, from c to D is equal to one if from C to C# text and here we hear the difference in sound The eastern mark is Half of if soaked from the frequency of the sound in half to become from C to C# quarter of a distance and not half in form and hearing

AaronDavidNewman commented 4 years ago

I think you are talking about the way the symbols sound. There were some bugs. I have an example in the file menu now that shows the tones and what they do. If you look in noteModifiers.js, the function 'SmoMicrotone.pitchCoeff' has the formula that I use, in 1/2 steps (so 0.5 on C is 1/2 between C and C#). Some of these were just a guess, and also I don't know how to do 'comma'. If you're interested, feel free to modify that and I'll pull it. Right now I'm treating them more like articulations than accidentals, they don't persist in the measure. I'm not sure if that is correct, either.

odaymusic commented 4 years ago

Cool, but there is a problem. How to add or delete a new note? Whereas, when trying to use delete for a tone, it erases an entire square and then opens an error window, and so on, with the use of ctr + z, what is the reason, and how is a note taken and modified?

On Sat, Feb 29, 2020 at 7:24 PM Aaron notifications@github.com wrote:

I think you are talking about the way the symbols sound. There were some bugs. I have an example in the file menu now that shows the tones and what they do. If you look in noteModifiers.js, the function 'SmoMicrotone.pitchCoeff' has the formula that I use, in 1/2 steps (so 0.5 on C is 1/2 between C and C#). Some of these were just a guess, and also I don't know how to do 'comma'. If you're interested, feel free to modify that and I'll pull it. Right now I'm treating them more like articulations than accidentals, they don't persist in the measure. I'm not sure if that is correct, either.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AaronDavidNewman/Smoosic/issues/16?email_source=notifications&email_token=AIBR6U3CPX5WH4PAFYVAHR3RFFCDLA5CNFSM4KPM5N2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENMAFWQ#issuecomment-592970458, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBR6U3AW3FROHO7V44QGWDRFFCDLANCNFSM4KPM5N2A .

AaronDavidNewman commented 4 years ago

Edit: I see what you mean about the error box. That's a bug! You should not be able to delete the only measure.

It depends on what you mean by delete. To toggle note to rest, the key is 'r'. Delete key deletes an entire measure. If you want to reduce the number of beats in a measure, you can use the measure dialog.

odaymusic commented 4 years ago

I mean, I can't add or delete tones

On Thu, May 21, 2020 at 4:24 AM Aaron notifications@github.com wrote:

It depends on what you mean by delete. To toggle note to rest, the key is 'r'. Delete key deletes an entire measure. If you want to reduce the number of beats in a measure, you can use the measure dialog.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AaronDavidNewman/Smoosic/issues/16#issuecomment-631839751, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBR6U73GCBL4IZPI5UP4BDRSSGGHANCNFSM4KPM5N2A .

odaymusic commented 4 years ago

When I click New until I write a new score, only four tones appear. They cannot be deleted, added, or deleted one tone alone.

‪On Thu, May 21, 2020 at 10:54 PM ‫مزيكاتي - Mazzekaty‬‎ < arranger.oday@gmail.com> wrote:‬

I mean, I can't add or delete tones

On Thu, May 21, 2020 at 4:24 AM Aaron notifications@github.com wrote:

It depends on what you mean by delete. To toggle note to rest, the key is 'r'. Delete key deletes an entire measure. If you want to reduce the number of beats in a measure, you can use the measure dialog.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AaronDavidNewman/Smoosic/issues/16#issuecomment-631839751, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBR6U73GCBL4IZPI5UP4BDRSSGGHANCNFSM4KPM5N2A .

AaronDavidNewman commented 4 years ago

I fixed the bug with deleting measures, and the 'ghost' tones that appeared.

The duration of notes in a measure always matches the time signature. You can reduce the number of notes in the measure by reducing the beats in a time signature, down to a single 1/8 note, if you want. You can increase the duration of notes, etc. But there always has to be at least one measure and measures are never 'empty'. I will probably add ability to 'hide' notes at some time, but right now I am focused on formatting.

odaymusic commented 4 years ago

Do you have Skype until we speak better to develop this .. We can win well if we develop this model .. Where I can market this product to Arab schools and universities because this is a talk and the first of its kind if it happens and this will enable me to attract investors and donors to develop the program, what do you think? To talk about that and do you have any problems if we participate in helping you to develop the design for the program?

On Fri, May 22, 2020 at 12:42 AM Aaron notifications@github.com wrote:

I fixed the bug with deleting measures, and the 'ghost' tones that appeared.

The duration of notes in a measure always matches the time signature. You can reduce the number of notes in the measure by reducing the beats in a time signature, down to a single 1/8 note, if you want. You can increase the duration of notes, etc. But there always has to be at least one measure and measures are never 'empty'. I will probably add ability to 'hide' notes at some time, but right now I am focused on formatting.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AaronDavidNewman/Smoosic/issues/16#issuecomment-632382751, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBR6U7662NH7D3MNMYBQ4DRSWU43ANCNFSM4KPM5N2A .

AaronDavidNewman commented 4 years ago

What you have been doing is great. I'd welcome any help with the application, including donations of code, testing, documentation etc. I'm not looking for money donations at this point, just community participation. Also, the javascript part of Smoosic will always be free and open-source, so there's nothing to 'market' at this point.

odaymusic commented 4 years ago

ok see this update https://drive.google.com/file/d/1U6--8AWrPhIYKfqRj48WDl_ou619t3MW/view?fbclid=IwAR1VgIPhNmbFe0-wR1-nRIrMt9wmzf6Qd7oJmcVSmtxrRcCoBPC_zXXZ9Eg

On Fri, May 22, 2020 at 10:52 PM Aaron notifications@github.com wrote:

What you have been doing is great. I'd welcome any help with the application, including donations of code, testing, documentation etc. I'm not looking for money donations at this point, just community participation. Also, the javascript part of Smoosic will always be free and open-source, so there's nothing to 'market' at this point.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AaronDavidNewman/Smoosic/issues/16#issuecomment-632904669, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBR6U7D65X3VJTO25KN3YTRS3QYZANCNFSM4KPM5N2A .

AaronDavidNewman commented 4 years ago

I like this a lot. You are clearly a better graphic artist than I am. Let me think for a bit on how to get the application fully multi-lingual. It should be possible to support multiple languages (including R-L) with the same css using the flex model, and just changing the html direction attribute. right now I am using a mix of absolute positioning and flex and it is a little sloppy.

You might want to use this for the vexflow link. The link you used will come and go - it is for my contributions to vexflow. This one is stable for smoosic: https://aarondavidnewman.github.io/vexflow_smoosic/releases/vexflow-debug.js

It would be nice to have the piano scroll-able (right to left) for the full piano range.

AaronDavidNewman commented 4 years ago

The latest version of Smoosic allows switching between translations, EN to AR. There is a language_ar.js file. If you are so inspired, you could create the translations in that file and submit as a pull request. Anything with 'label' or 'text' is translated text. Anything else is an identifier so you can tell the context. I'll post some more info later when I have time. Edit: I forgot to mention, the text direction is now automatic and part of the css.

AaronDavidNewman commented 4 years ago

Hi @odaymusic , I have created some translation tools if you are interested in contributing any more Arabic translations to Smoosic. I pulled what I could from 'nota', but as I don't speak or read Arabic, I am hesitant to do too much.

Link to translation tool: https://aarondavidnewman.github.io/Smoosic/release/html/smoosic.html?translate=ar

Link to Wiki for instructions. https://github.com/AaronDavidNewman/Smoosic/wiki/Internationalizing-Smoosic

Also if 'nota' has a location on GitHub, I'd like to stay up with any changes.

I will be closing this issue in a couple of weeks, since it covers a couple of issues that have been fixed. Feel free to open a ticket if you have more suggestions, or a pull request with any translations or changes.

odaymusic commented 3 years ago

Hello

We returned, we had some works that made us move away from the music and developments. I am happy with your developments in the library. We hope that some additions will be made, such as that the player accepts midi and music xml files in order to be able to play any music files .. Also the editor needs the ability to add and delete tones as not Now it is possible to add or delete tones in addition to the emergence of a problem trying to delete anything and restart it. Is it possible that there are these developments ??

On Sun, Jun 7, 2020 at 8:01 PM Aaron notifications@github.com wrote:

The latest version of Smoosic allows switching between translations, EN to AR. There is a language_ar.js file. If you are so inspired, you could create the translations in that file and submit as a pull request. Anything with 'label' or 'text' is translated text. Anything else is an identifier so you can tell the context. I'll post some more info later when I have time.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AaronDavidNewman/Smoosic/issues/16#issuecomment-640256326, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBR6U7MMHWEMC6PG72IL5DRVPIWFANCNFSM4KPM5N2A .

AaronDavidNewman commented 3 years ago

Welcome back. I'm not sure if I understand about 'add or delete tones '. Do you want to be able to add notes to a measure, beyond the time signature (like a cadenza)?