Db major / Bb minor key signature

AaronDavidNewman / Smoosic

A music notation editor written in javascript

Other

98 stars 14 forks source link

Closed rkr1209 closed 3 years ago

rkr1209 commented 3 years ago

Hi Aaron,

typo: accidentals/icon not shown in key signature menu smoosic.js:41347 icon: 'key-sig-bd', -> icon: 'key-sig-db',
key signature is wrong (but unfortunately I can not find where the issue is). It displays 7 sharps instead of 5 flats. I'm sure it was correct in an earlier version from mid of last year, but don't find which update has caused this. Would be great if you could check it. :-)

Best, R

AaronDavidNewman commented 3 years ago

How embarrassing! I just pushed a PR that fixes this. Edit: Db and C# are now handled correctly. Icon is a lesser issue.

rkr1209 commented 3 years ago

brilliant! Thanks!