search

AaronDavidNewman / Smoosic

A music notation editor written in javascript
Other
100 stars 14 forks source link

copy paste sometimes throws an exception when note doesn't fit #8

Closed AaronDavidNewman closed 4 years ago

AaronDavidNewman commented 4 years ago

...if the remainder isn't in the table smoMusic.ticksToDuration. If this happens, the logic should divide the remainder into units of GCD of the remainder that is in the table, and then combine those units into the largest unit possible. An example of what will cause this: pasting a dotted-whole into a measure of eighth notes in 12/8 time, at the 2nd tick position.

AaronDavidNewman commented 4 years ago

I fixed this some time ago, and just re-tested this, Closing.