Support InfinityBook Pro 14

milgner commented 1 year ago

I wonder what would need to be done to add support for InfinityBook Pro 14?

In Tailor GUI it currently only says that performance profiles are not available and I can't configure anything. I'd be very open to adding support - good excuse to write some Rust code :smiley_cat: - but I'm not sure where to start.

AaronErhardt commented 1 year ago

If it says that performance profiles are not available, it's very likely that the kernel driver does not support them (though it would be interesting to know whether TCC shows anything). Usually, there shouldn't be any device-specific code required.

So if your InfinityBook Pro works with tuxedo-rs, we could add it to the list of tested devices.

milgner commented 1 year ago

TCC shows all the options to configure battery and CPU behaviour. I'm not sure which functionality is part of the performance profiles but currently the Tailor GUI is more or less blank.

AaronErhardt commented 1 year ago

the Tailor GUI is more or less blank.

In this case, we have to look into this. Tuxedo-rs supports fan curves, keyboard LED animations and (on some devices) performance profiles (like "performance" or "quite" for example). If those don't work in the GUI, we should dig deeper to figure out why. Additionally, since I haven't touched TCC in a while, I forgot which feature it has, so suggestions about missing features are also great.

It would be great if you could check your device starting from the lowest abstraction layer: tuxedo-io and tuxedo-keyboard. Those interface with ioctl and sysfs and if they already return something bad, we know where to fix it. You can also find the whole structure of the crates here :)

jake1909 commented 1 year ago

I am on nixos with infinity book pro 14. I can confirm the blank interface although the controls seems to be there. I can adjust the fans in the blind. Also, the keyboard lightning seems broken. When activating with FN+Space it just blinks once.

nicos68 commented 1 year ago

Also, the keyboard lightning seems broken. When activating with FN+Space it just blinks once.

Hi, I just tried on my machine and had the same behavior. I think this is due to the fact that by default tailord (or maybe some other component) sets the led profile to "multiple", which I guess corresponds to rgb keyboard backlight, so if you have a monochrome backlit keyborad as is my case it fails. When I switched my LED profile to "single" then everything would work as before again and I can now adjust the intensity:

wvengen commented 1 year ago

$ sudo dmidecode -s system-product-name
TUXEDO InfinityBook Pro 14 Gen6
$ uname -a
Linux <host> 6.5.0-10005-tuxedo #5 SMP PREEMPT_DYNAMIC <date> x86_64 x86_64 x86_64 GNU/Linux
$ cargo install tailor_hwcaps --git https://github.com/AaronErhardt/tuxedo-rs
Installing tailor_hwcaps v0.2.1 (https://github.com/AaronErhardt/tuxedo-rs#388e5fc9)
...
$ sudo tailor_hwcaps
[OK]    Module version: "0.3.9\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"
[OK]    Device interface ID: "uniwill_wmi\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"
[OK]    Model ID: "18"
[OK]    Available ODM performance profiles: []
[ERR]   Default ODM performance profile: DevNotAvailable
[OK]    Number of fans: 1
[OK]    Fan temperatures [°C]: [45]
[OK]    Fan speeds [%]: [0]
[OK]    Fan min speed [%]: 20
[INFO]  Webcam control is not available
[OK]    number_of_tdp_devices: 2
[OK]    tdp_descriptors: ["pl1", "pl2"]
[OK]    tdps: [50, 50]
[OK]    max_tdps: [50, 50]
[OK]    min_tdps: [5, 5]
[OK]    Number of LED devices: 0

The TUXEDO Control Center 2.0.11 shows: CPU-Temp control, CPU-Frequency control, CPU-Fan control, (Performance) Profiles, Crypt Password, Shutdown Timer, Webcam, Battery charging options (charging profiles, USB-C charging options), Tomte. Not supported: Keyboard Backlight ("is not (yet) supported by this control interface, or the driver is too old").

SimonBrandner commented 11 months ago

Is there anything that can be done to aid in improving the situation here?

(I am somewhat stuck on the previous version of NixOS due to this)

AaronErhardt commented 11 months ago

Is there anything that can be done to aid in improving the situation here?

Sure, there are a couple of things to investigate. First of all, it would be nice for me to know what works and what doesn't. Earlier reports say that the GUI is blank, but it seems that tailord is partially working. Someone said the "multiple" color profile caused problems (likely due to monochrome LEDs), but the latest tailor_hwcaps report says that there are 0 LED devices detected...

Also if it's true that TCC supports performance profiles whereas their ioctl interface doesn't provide any, that'd also be something to investigate as well...

wvengen commented 11 months ago

Regarding the keyboard backlight, I can report what happens with the software from Tuxedo (same device as here):

Pressing Fn-Space cycles through the states: off, half, full.
When pressing Fn-Space, an indicator is shown on screen.
TUXEDO Control Center tells that it "is not (yet) supported by this control interface, or the driver is too old"

It seems that gnome-settings-daemon handles this. sudo evtest /dev/input/by-path/platform-tuxedo_keyboard-event shows, when pressing Fn-Space:

Input driver version is 1.0.1
Input device ID: bus 0x19 vendor 0x0 product 0x0 version 0x0
Input device name: "TUXEDO Keyboard"
Supported events:
  Event type 0 (EV_SYN)
  Event type 1 (EV_KEY)
    Event code 56 (KEY_LEFTALT)
    Event code 64 (KEY_F6)
    Event code 125 (KEY_LEFTMETA)
    Event code 191 (KEY_F21)
    Event code 228 (KEY_KBDILLUMTOGGLE)
    Event code 229 (KEY_KBDILLUMDOWN)
    Event code 230 (KEY_KBDILLUMUP)
    Event code 240 (KEY_UNKNOWN)
    Event code 247 (KEY_RFKILL)
  Event type 4 (EV_MSC)
    Event code 4 (MSC_SCAN)
Properties:
Testing ... (interrupt to exit)
Event: time 1702581466.631438, type 4 (EV_MSC), code 4 (MSC_SCAN), value 3d
Event: time 1702581466.631438, type 1 (EV_KEY), code 228 (KEY_KBDILLUMTOGGLE), value 1
Event: time 1702581466.631438, -------------- SYN_REPORT ------------
Event: time 1702581466.631451, type 1 (EV_KEY), code 228 (KEY_KBDILLUMTOGGLE), value 0
Event: time 1702581466.631451, -------------- SYN_REPORT ------------

dbus-monitor shows, when pressing Fn-Space:

method call time=1702581303.566398 sender=:1.64 -> destination=:1.63 serial=11006 path=/org/gnome/SettingsDaemon/Power; interface=org.gnome.SettingsDaemon.Power.Keyboard; member=Toggle
method return time=1702581303.566543 sender=:1.63 -> destination=:1.64 serial=14007 reply_serial=11006
   int32 0
signal time=1702581303.566696 sender=:1.63 -> destination=(null destination) serial=14008 path=/org/gnome/SettingsDaemon/Power; interface=org.freedesktop.DBus.Properties; member=PropertiesChanged
   string "org.gnome.SettingsDaemon.Power.Keyboard"
   array [
      dict entry(
         string "Brightness"
         variant             int32 0
      )
   ]
   array [
   ]
signal time=1702581303.566743 sender=:1.63 -> destination=(null destination) serial=14009 path=/org/gnome/SettingsDaemon/Power; interface=org.gnome.SettingsDaemon.Power.Keyboard; member=BrightnessChanged
   int32 0
   string "Toggle"
method call time=1702581303.566790 sender=:1.64 -> destination=:1.37 serial=11007 path=/org/gnome/Shell; interface=org.gnome.Shell; member=ShowOSD
   array [
      dict entry(
         string "icon"
         variant             string "keyboard-brightness-symbolic"
      )
      dict entry(
         string "level"
         variant             double 0
      )
   ]

When stopping tccd, I can confirm that this keeps working. My conclusion would be that tuxedo-rs doesn't need to touch the keyboard backlight on this device.

wvengen commented 11 months ago

Looking at changing performance profiles, I tried strace-ing tccd, which yielded these lines when switching profiles:

write(1, "ODMPowerLimitWorker: Set ODM TDP"..., 57) = 57
openat(AT_FDCWD, "/dev/tuxedo_io", O_RDWR) = 21
ioctl(21, _IOC(_IOC_READ, 0xec, 0x5, 0x8), 0x7ffe7baa1bdc) = 0
ioctl(21, _IOC(_IOC_READ, 0xec, 0x6, 0x8), 0x7ffe7baa1bdc) = 0
ioctl(21, _IOC(_IOC_READ, 0xef, 0x1a, 0x8), 0x7ffe7baa1cfc) = 0
ioctl(21, _IOC(_IOC_READ, 0xef, 0x19, 0x8), 0x7ffe7baa1cfc) = 0
ioctl(21, _IOC(_IOC_WRITE, 0xf0, 0x15, 0x8), 0x7ffe7baa1d2c) = 0
ioctl(21, _IOC(_IOC_WRITE, 0xf0, 0x16, 0x8), 0x7ffe7baa1d2c) = 0
close(21)                               = 0

(note that there is of course a lot more going on, this was what I could detect being different from no profile switching, but there must be more going on here).

Only the first line would differ when a different profile was selected. Syslog showed e.g. when switching to quiet profile:

tccd[...]: ODMPowerLimitWorker: Set ODM TDPs ["10 W","15 W","25 W"]

and switching back to default profile:

tccd[...]: ODMPowerLimitWorker: Set ODM TDPs ["50 W","50 W"]

In this file we find the ioctl constants, so (hoping I made no mistakes):

0xec, 0x05 would be R_HWCHECK_CL with int32_t* arg (happens all the time)
0xec, 0x06 would be R_HWCHECK_UW with int32_t* arg (happens all the time)
0xef, 0x1a would be R_UW_TDP2 with int32_t* arg
0xef, 0x19 would be R_UW_TDP1 with int32_t* arg
0xf0, 0x15 would be W_UW_TDP0 with int32_t* arg
0xf0, 0x16 would be W_UW_TDP1 with int32_t* arg