search

AaronGullickson / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.info/mekhq
2 stars 0 forks source link

Concurrency issue when assigning WaitStoryPoint from newday #30

Closed AaronGullickson closed 8 months ago

AaronGullickson commented 8 months ago

I noticed that when I was running through the young wolves story arc, when Marco Halls dialog tells you about the blood trial one day away, you then instantly advance. I believe the issue here is that hall's dialog is triggered by the newday check in Story Arcs from an existing WaitStoryPoint. It then triggers another WaitStoryPoint which may or may not get instantly processed if its still waiting the loop queue of that check.

AaronGullickson commented 8 months ago

I fixed this in 98ae373262 by having WaitStoryPoint create an absolute date from the days variable when it is started.