Closed AaronGullickson closed 5 years ago
I think some fixes could work in the get_colony_sics function. We could put an explicit check for Terra here. We could also check the sics code after the randomness is added to make sure we haven't made values higher than reasonable for the founding year (e.g. A-rated in 2200).
The other issue is the interpolate_sics function which does not pay attention to such things as whether values are realistic, so you could get a planet jumping to A-rated tech shortly after its founding in 2200. I don't know if there is much I can do here, without some serious reworking, but I will think on it.
It might also be easier to adjust the dates of Terra's changes by hand after the processing.
One possibility on the interpolation function is to put a check in on reasonable years for certain levels and keep it in a while loop until it gets it right. Just need to make sure it doesn't get caught in an infinite loop if there are certain impossible cases.
The only codes that should be affected by this are Tech and Industrial Development. We just need to set thresholds for when the A (and maybe B) levels are possible. We can then put a check in the code.
After processing. We should change Terra's USILR events to be the earliest possible dates as it should be leading.
fixed by commit cited above. I set 2400 and 2600 as the two cutoff points for B and A tech ratins respectively and 2600 as the cutoff for A industry ratings.
The USILR reverse projections from SL era to founding are a little wonky. A big jump in tech ratings, for example, within the span of 2600-2650. Terra stays at Tech C until late 2500s when it jumps rapidly from B and then to A.
Not sure how much its worth it to worry about these details but the completist in me says address it now if possible.