search

AaronLasseigne / active_interaction

:briefcase: Manage application specific business logic.
MIT License
2.07k stars 137 forks source link

Provide more fluent interface to handle boolean filter #559

Closed heka1024 closed 1 year ago

heka1024 commented 1 year ago

It would be nice to be able to use a boolean filter like <filter_name>? instead of <filter_name>.

AaronLasseigne commented 1 year ago

We used to generate predicate methods for each input to see if it was given. With that dropped in 4.0.0 we can do something like this now. It's also far enough away from what it used to do that I think I shouldn't mess up people upgrading.

AaronLasseigne commented 1 year ago

There are a couple of linting errors but I think this is a good idea.

heka1024 commented 1 year ago

@AaronLasseigne I fixed linting errors. Could you review this PR once again?

AaronLasseigne commented 1 year ago

Thanks!