search

AaronLasseigne / active_interaction

:briefcase: Manage application specific business logic.
MIT License
2.06k stars 136 forks source link

Add JRuby 9.4 #563

Closed skunkworker closed 1 year ago

skunkworker commented 1 year ago

I noticed that JRuby was dropped at 5.0 due to the syntax being out of date, now that JRuby 9.4 is bringing 3.1 syntax I feel this would be a good time to reintroduce it.

AaronLasseigne commented 1 year ago

It wasn't dropped because of syntax. It was dropped because it made it harder to figure out which JRuby versions equate to standard Ruby and I didn't see it being used widely enough to warrant the effort.

skunkworker commented 1 year ago

Is there anything I can do in order to maintain that compatibility? At my current workplace we use jruby-9.3/9.4 and this gem.

And for ruby compatible syntax JRuby-9.3=2.6 and JRuby-9.4=3.1

skunkworker commented 1 year ago

But in reality as long as there is no dependency of a c extension library I do not foresee any JRuby specific bugs and it will probably work just fine.

AaronLasseigne commented 1 year ago

Like you said, it should just work. I don't use JRuby so trying to keep up with which version maps to which CRuby version was more trouble than it was worth. Is there a mapping from JRuby -> CRuby versions somewhere? I've looked for it and didn't have much success.

skunkworker commented 1 year ago

https://en.wikipedia.org/wiki/JRuby#Release_history Is probably the most centralized, along with the release notes in https://www.jruby.org/news