search

AaronRobinsonMSFT / DNNE

Prototype native exports for a .NET Assembly.
MIT License
394 stars 41 forks source link

Add -Wno-atomic-align #173

Closed jtschuster closed 1 year ago

jtschuster commented 1 year ago

On Linux arm dotnet/runtime builds, this atomic instruction in platform.c warns.

https://github.com/AaronRobinsonMSFT/DNNE/blob/3657e77c4a988054ea8c0a84122b5bb450503b49/src/platform/platform.c#L298-L301

To silence the warning, use "-Wno-atomic-alignment" for clang.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=354415&view=logs&j=fbba4562-0196-5144-0bc8-97e5ecde48bd&t=965fe576-127f-568f-354c-a3511c13c4cb&l=2414

I haven't yet confirmed this change fixes the issue.

AaronRobinsonMSFT commented 1 year ago

We shouldn't add this flag. I see the issue. I'll make the fix in source.

AaronRobinsonMSFT commented 1 year ago

@jtschuster I'm going to close this in lieu of #174