AaronRobinsonMSFT / DNNE

Prototype native exports for a .NET Assembly.
MIT License
397 stars 41 forks source link

Use the C standard errno.h header instead of the GCC-specific sys/errno.h #89

Closed jkoritzinsky closed 2 years ago

jkoritzinsky commented 2 years ago

Alpine doesn't support the sys/errno.h header and emits a warning when redirecting the include.

See https://dev.azure.com/dnceng/public/_build/results?buildId=1399511&view=logs&j=3cb0d069-7bfd-5845-3f2b-3f0219fe1975&t=f32c8f8b-0718-5785-0642-67a45b7d0ab2&l=2538

AaronRobinsonMSFT commented 2 years ago

@jkoritzinsky I just want to commit this but I think we may need to branch on macOS. I will validate that tomorrow. I agree this PR would be ideal.

AaronRobinsonMSFT commented 2 years ago

Confirmed this works on macOS with the update. At some point I need to use GitHub actions and make the CI work...