AaronSadlerUK / Our.Umbraco.UmbNav

Drag and drop menu editor for Umbraco V8, V9 and V10+
MIT License
10 stars 15 forks source link

Improve multilingual support #32

Open AaronSadlerUK opened 3 years ago

AaronSadlerUK commented 3 years ago

Currently the multilingual support is clunky to say the least.

It would be nice to be able to choose any enabled language in the node picker, handle the fallbacks gracefully and improve the underlying code for the multilingual part

olibos commented 3 years ago

Hello,

I was just looking at your package for a new Umbraco project, I think your package is really interesting! But I had the same issue when I'm trying it on few pages with multiple culture variations...

Do you have any idea to improve it? Maybe I can help.

AaronSadlerUK commented 3 years ago

The biggest improvement would be to add a language dropdown to the node picker, so you could switch between languages.

Also I know there is a bug where if you don't specify a menu in a language, and then it falls back, the link gets added with no title.

But other than that, I'm not sure on use cases, other than it's clunky 😂

Open to ideas at this point

mrrm commented 1 year ago

When I build a menu of items that allow "vary by culture", the menu links are not shown

mrrm commented 1 year ago

Fixed passing "" in the culture. But when I clean backoffice cache, it disappears again

AaronSadlerUK commented 1 year ago

Have you tried passing in the current culture when rendering out?

mrrm commented 1 year ago

yes, I've tried. the same issue when reloading cache in the backoffice happens. Just the labels in the menu navigation are shown, not the links. I'm using 1.1.4 version on Umbraco 8.16.0 . The issue happens when the nav was built using link to pages(nodes), not when the links use full url. Not all page nodes have content for the second defined language. To allow the complete navigation appears(including links) is necessary to re-run the application o re-deploying. The site is hosted in azure, I have 2 sites using multisite feature on Umb8. I have 2 domains to access the same site. In one domain the issue occurs, in the other the menu works okay