AaronSadlerUK / Our.Umbraco.UmbNav

Drag and drop menu editor for Umbraco V8, V9 and V10+
MIT License
10 stars 15 forks source link

Image on Child is not working #6

Closed ziyadsv closed 3 years ago

ziyadsv commented 3 years ago

Which exact Umbraco version are you using? For example: 8.7.0 - don't just write v8 or v9

v8.15.2

Bug summary

parent image is showing but the image on the child is not working.

Specifics

No response

Steps to reproduce

``@foreach (var item in nav.UmbNav) {

@item.Title

            @if (item.Children.Count() != 0)
            {
                <ul>
                    @foreach (var child in item.Children)
                    {                            
                        <li>
                            @if (child.Image != null)
                            {
                                <img alt="@child.Image.Name" src="@child.Image">
                            }                                
                            <a href="@child.Url()" target="@child.Target" rel="@child.Noopener @child.Noreferrer">@child.Title</a>
                        </li>
                    }
                </ul>
            }
    }``

Expected result / actual result

The result of child item image is null.

AaronSadlerUK commented 3 years ago

I will look into this and issue a patch soon ☺

AaronSadlerUK commented 3 years ago

Ok so I've taken a look at this, and I am unable to replicate with the latest rc (1.0.0-rc.9)

Can you try clicking edit on the affected menu item, re-select the picture and then Save and Publish to see if it resolves it.

I have updated the navbar testing code to show what I've used to test here: https://github.com/AaronSadlerUK/Our.Umbraco.UmbNav/blob/46cef503da96d757bda922cfcb51e33d6d589241/TestSite/Views/Partials/Navigation/TopNavigation.cshtml

ziyadsv commented 3 years ago

Will you please check with the latest umbraco version 8.17.0-rc . Am using three UmbNav on one page. but sometimes it's not showing the image. after i uninstall and reinstall the UmbNav package it didn't show me entire menu

On Thu, Sep 2, 2021 at 10:30 PM Aaron @.***> wrote:

Closed #6 https://github.com/AaronSadlerUK/Our.Umbraco.UmbNav/issues/6.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AaronSadlerUK/Our.Umbraco.UmbNav/issues/6#event-5249590557, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4WMXZQ7KTRI6VGWNEIWGDT77GEBANCNFSM5DBZOY4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.