search

Aaronius / penpal

A promise-based library for securely communicating with iframes via postMessage.
MIT License
389 stars 56 forks source link

Updated types to fix multiple exports error and updated README #17

Closed paulblyth closed 6 years ago

paulblyth commented 6 years ago

This should fix #16

paulblyth commented 6 years ago

@Aaronius is the TypeScript import of Penpal and the error codes the same as JavaScript? Didn't have time to check the vanilla JS import to see if it was the same, but you're exporting Penpal as default so I expect so?

paulblyth commented 6 years ago

Also build failing but I don't know why a change to the types and readme would break it.. 😇

Aaronius commented 6 years ago

Thanks for helping out @paulblyth. I don't think I understand your question in https://github.com/Aaronius/penpal/pull/17#issuecomment-353300315. It seems like the answer is probably yes. If you could clarify though I could tell you for sure.

Yeah, TravisCI and SauceLabs seem to be super finicky. Don't worry about it.

Aaronius commented 6 years ago

Thanks for your help! Released in 3.0.1.