search

Aaronius / penpal

A promise-based library for securely communicating with iframes via postMessage.
MIT License
389 stars 56 forks source link

CI and Browser testing #5

Closed loganvolkers closed 6 years ago

loganvolkers commented 7 years ago

It would nice to see CI running for this project and for that to include some browser testing. 😄

I noticed that IE support is only for IE 10+, but it's nice to see that as a badge on the project page:

image

Sauce Labs has free browser testing for open source projects: https://saucelabs.com/open-source https://saucelabs.com/beta/signup/OSS/None

Aaronius commented 7 years ago

Yes! I agree. My schedule for the next several weeks does not look promising for this work (trip to California, conference in Switzerland, moving to a new house) but I really would like to do this. I'm willing to give rights to anyone who may want to help out with this.

Aaronius commented 6 years ago

Fixed. There was one test failing for IE 10 that could probably be fixed (it's a specific scenario that most people probably wouldn't run into), but IE 10 usage is so low I decided I didn't want to deal with it. I've said that v11 is the only IE supported now. I still need to make the tests run on iOS and Android.

loganvolkers commented 6 years ago

❤️ 😍