search

Aaronius / penpal

A promise-based library for securely communicating with iframes via postMessage.
MIT License
381 stars 56 forks source link

Automate tests #88

Closed celesterobinson closed 2 years ago

celesterobinson commented 2 years ago

This PR adds a new workflow to run automated tests using sauce labs on new PRs and pushes.

Aaronius commented 2 years ago

Hey @celesterobinson, do you know what remains here? Chrome problems?

celesterobinson commented 2 years ago

I can't remember the exact issue, but yeah there were issues with Chrome actually launching the test suite. I think I kind of came to the conclusion that SauceLabs might not be the right solution with Github Actions though.

celesterobinson commented 2 years ago

I think the biggest hurdle I was facing was using saucectl. It requires Cypress, Playwright, or TestCafe. I was trying to make it work without one of those frameworks, but hadn't had any luck yet. So we could incorporate one or use something other than SauceLabs like Browserstack. I think we'd still need TestCafe or something similar for that though.

Aaronius commented 2 years ago

Hey @celesterobinson, I think we should switch to BrowserStack. I'm going to close this PR. Thanks for your efforts!

celesterobinson commented 2 years ago

Sounds good! Sorry I haven't had a chance to get back at this yet. I think browser stack is a good move