search

Aatch / ramp

RAMP - Rust Arithmetic in Multiple Precision
Apache License 2.0
263 stars 38 forks source link

Remove the word "trailing" from Int::count_ones() #126

Closed PrisionMike closed 2 years ago

PrisionMike commented 3 years ago

The function Int::count_ones() returns the number of ones (population count, as rightly said in the docs). The docs however state number of "traliling" ones which is misleading. I would like to request we drop the term.

Thanks for the PR! Would you mind rebasing it on the current master? It looks like most of these changes are wrt a 4 year old version of the repo.

I am very new to GitHub. I think I've added another PR to the main branch with the edit. I can't figure out how to delete this one. Kindly review the main PR and remove it if you can. Thank you

rozbb commented 3 years ago

Thanks for the PR! Would you mind rebasing it on the current master? It looks like most of these changes are wrt a 4 year old version of the repo.

rozbb commented 2 years ago

Closed along with #127. Thanks for catching this!