AathifMahir / MauiIcons

MauiIcons is Icon Collection Library for .Net Maui
MIT License
217 stars 13 forks source link

Icon color does not follow theme change with AppThemeBinding #122

Open hugebug4ever opened 1 day ago

hugebug4ever commented 1 day ago

Describe the bug Icon color does not apply the theme color with AppThemeBinding, within the same process. It only apply on widget creation.

To Reproduce Steps to reproduce the behavior:

  1. Create a Maui App project with dotnet 9.0
  2. Add an maui icon to the screen
  3. Specify a Icon color to the IconColor property, with AppThemeBinding
  4. Siwthc app theme ( same app instance ), inspcect the icon color
  5. The icon color does not change, but the label color is changed as expected
  6. If I kill the process and restart the app again, the icon color changed as expected.

Expected behavior The icon color should change with the theme changing.

Screenshots Code sample: image App with light theme: image App with dark theme set dynamically: image

Desktop and Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

AathifMahir commented 14 hours ago

Describe the bug Icon color does not apply the theme color with AppThemeBinding, within the same process. It only apply on widget creation.

To Reproduce Steps to reproduce the behavior:

  1. Create a Maui App project with dotnet 9.0
  2. Add an maui icon to the screen
  3. Specify a Icon color to the IconColor property, with AppThemeBinding
  4. Siwthc app theme ( same app instance ), inspcect the icon color
  5. If I restart the app, the color does not change, but the label color is changed as expected

Expected behavior The icon color should change with the theme changing.

Screenshots Code sample: image App with light theme: image App with dark theme set dynamically: image

Desktop and Smartphone (please complete the following information):

  • OS: iOS, Windows. (Android should be the same)
  • Version: 4.0.0

Additional context Add any other context about the problem here.

It seems like bug, I'll push a patch to fix this issue as soon as possible