Aatmaj-Zephyr / Basic-memory-game

This is a basic "memory game" which is implemented for practising java script
MIT License
5 stars 14 forks source link

UI-Edit: When flipping tiles "face-up", the difference in size can be jarring and makes it harder to play #104

Closed a-parris21 closed 1 year ago

a-parris21 commented 1 year ago

The Problem To start, I would say this is more of a QoL suggestion, rather than a bug-fix. I played the simulation a few times and noticed that the images for the characters are not all the same size. Most of the time this is not problematic but for certain characters (such as Wolf, Sonic, Diddy Kong, and Kirby; Kirby especially) their images are much larger than the other images displayed. And this causes the 'tiles' to get moved farther down the screen or farther up.

Possible Solution A clear and concise description of what you want to happen. I would like that the size parameters are modified for the rendered images so that either:

Additional context Most of the characters do not have a significant impact on the simulation, however:

a-parris21 commented 1 year ago

Can I be assigned this issue? I'd like to implement this solution myself. It shouldn't be too complicated. Probably just some CSS edits.

github-actions[bot] commented 1 year ago

Thanks for the issue! Please feel free to wirk on it if you would like to!

a-parris21 commented 1 year ago

Submitted a PR which fixes this issue.