Aatmaj-Zephyr / Basic-memory-game

This is a basic "memory game" which is implemented for practising java script
MIT License
5 stars 15 forks source link

removed tiles background in starting #116

Closed Anurag-Sarkar closed 1 year ago

Anurag-Sarkar commented 1 year ago

What does this PR do?

On the starting of the game the tiles have a box shadow which revealed the white background of the tiles.

Screenshots of changes made to the webapp.

I removed the box shadow and removed the add style line in the loop that added that box styling to all the other boxes. I verified it by playing the game and it worked all okay as I just changed the styling not any actual logic.

Related PRs and Issues

It is related to the PR issue #92 which also was raised to remove the background of tiles. but removing the box shadow was alo important

Have you updated the README.md file?

Have you made any big breakthrough change?

Is the code beautified?

Is the code clear to understand woth proper variable naming and comments?

Anurag-Sarkar commented 1 year ago

Sorry I am new to contribution and learning, I hope I did all the things you asked for.

Aatmaj-Zephyr commented 1 year ago

Sure no probs. Thanks for the efforts

Anurag-Sarkar commented 1 year ago

Thanks a lot this was my first contribution, I really appreciate it