Aatmaj-Zephyr / Basic-memory-game

This is a basic "memory game" which is implemented for practising java script
MIT License
5 stars 15 forks source link

[feature]: Add images to the game #81

Closed Rafajrg21 closed 1 year ago

Rafajrg21 commented 1 year ago

What does this PR do?

This PR makes it so instead of just letters, it shows 16 cards from a collection of images, some styling was modified as well to have a better presentation of such images. This new functionality can be extended by creating different themes for the game, adding replay value.

The images are smash bros related, because it was the first thing I thought of.

Related PRs and Issues

This solves issue #75

Screenshots of changes made to the webapp.

A new game looks like this

Already in the game

Have you updated the README.md file?

Have you made any big breakthrough change?

Is the code beautified?

Is the code clear to understand with proper variable naming and comments?

Aatmaj-Zephyr commented 1 year ago

Thanks for the work! Please fill the pull request template with appropriate checklist and screenshots so I can approve and merge it

Rafajrg21 commented 1 year ago

@Aatmaj-Zephyr are those screenshots enough? Should I add anything else?

Aatmaj-Zephyr commented 1 year ago

Thanks