search

AbanteAI / mentat

Mentat - The AI Coding Assistant
https://mentat.ai
Apache License 2.0
2.42k stars 226 forks source link

Two Step Edits #530

Open biobootloader opened 4 months ago

biobootloader commented 4 months ago

Pull Request Checklist

mentatbot[bot] commented 4 months ago

MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. Please Reply with feedback.

This pull request introduces a significant refactor and a new feature for handling two-step edits with the LLM. The changes overall are well-structured, and the separation of concerns between files is improved. However, there are several areas, particularly in the new stream_model_response_two_step function, that require attention to ensure the feature is complete and robust. Addressing the hardcoded model usage, ensuring TODOs are resolved, and handling potential assertion failures gracefully are key areas to focus on before finalizing this feature.

mentatbot[bot] commented 4 months ago

MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. Please Reply with feedback.

The introduction of the two-step edit process is a promising addition, enhancing the flexibility and capability of the system. However, attention to detail in handling edge cases, user control, and testing will be crucial to ensure its success and reliability. Addressing the mentioned concerns and implementing the suggested improvements will significantly contribute to the robustness and user satisfaction of this feature.