AbanteAI / mentat

Mentat - The AI Coding Assistant
https://mentat.ai
Apache License 2.0
2.42k stars 226 forks source link

Ragdaemon #540

Closed granawkins closed 2 months ago

granawkins commented 3 months ago

This aims to be the simplest possible integration of ragdaemon into mentat:

Pull Request Checklist

mentatbot[bot] commented 3 months ago

MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. Please Reply with feedback.

This PR introduces ragdaemon into Mentat, significantly altering how code context is managed. The changes are foundational and appear to streamline the process by leveraging ragdaemon's capabilities. Key considerations include ensuring backward compatibility, robustness in .gitignore handling, and the removal of ctags-related functionality. Additionally, the testing strategy should be adapted to cover these new integrations comprehensively. Documentation and examples on using the new Daemon-based approach would be beneficial for maintainers and developers.

mentatbot[bot] commented 3 months ago

MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. Please Reply with feedback.

This PR introduces significant changes by integrating ragdaemon into Mentat. Key areas to focus on include ensuring backward compatibility, precise documentation on the changes, and robust testing to cover the new functionalities. Additionally, consider specifying exact versions for dependencies like ragdaemon to ensure consistent and stable builds.

mentatbot[bot] commented 3 months ago

MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. Please Reply with feedback.

This PR introduces significant changes by integrating ragdaemon into Mentat. Key areas to focus on include ensuring backward compatibility, precise documentation on the changes, and robust testing to cover the new functionalities. Additionally, consider specifying exact versions for dependencies like ragdaemon to ensure consistent and stable builds.

mentatbot[bot] commented 3 months ago

MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. Please Reply with feedback.

This PR introduces significant changes by integrating ragdaemon into Mentat. Key areas to focus on include ensuring backward compatibility, precise documentation on the changes, and robust testing to cover the new functionalities. Additionally, consider specifying exact versions for dependencies like ragdaemon to ensure consistent and stable builds.

mentatbot[bot] commented 3 months ago

MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. Please Reply with feedback.

This PR introduces a foundational change by integrating ragdaemon into Mentat, significantly altering the code context management. It's crucial to ensure backward compatibility, robust testing, and clear documentation to facilitate a smooth transition. Additionally, pinning dependencies like ragdaemon to specific versions can help maintain consistent behavior across different environments.

granawkins commented 3 months ago

Tests passing (but behind main). Todo here:

Todo on ragdaemon before merging here:

mentatbot[bot] commented 3 months ago

MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. Please Reply with feedback.

The integration of ragdaemon into Mentat introduces significant changes, particularly in how code context is managed. It's crucial to ensure that these changes are well-documented, backward-compatible, and thoroughly tested. Additionally, consider specifying exact versions for dependencies like ragdaemon to ensure consistent and stable builds. The use of Path operations for file handling and the potential performance implications of the new Daemon-based approach should also be carefully considered.