AbcAeffchen / Sephpa

PHP class to create SEPA xml files for credit transfer and direct debit
GNU Lesser General Public License v3.0
71 stars 31 forks source link

Typing error in camel case variable key #1

Closed paulmorphy closed 10 years ago

paulmorphy commented 10 years ago

First of all many thanks for publishing this great tool. There are loads of SEPA-Export tools here on GitHub but this one is clearly on of the best in my opinion.

I just found a minor bug yesterday which I would like to report. In the file SepaDirectDebit.php on line 212 the condition if(isset($payment['rmtinf'])) must be if(isset($payment['rmtInf'])) with a capital I.

The evaluation of the key name is case sensitive, so the remittance information is never added if the key is given in correct camel case as in your example

Best regards Paul Morphy

AbcAeffchen commented 10 years ago

Thanks a lot. Im glad at least one have found my fork.

I have fixed this Bug 3 month ago, but I forgot to publish a new release so in v1.0.0 the bug is stil unfixed. I publish a new version. Thanks for your report.

Beste regards AbcAeffchen