search

AbcAeffchen / Sephpa

PHP class to create SEPA xml files for credit transfer and direct debit
GNU Lesser General Public License v3.0
71 stars 31 forks source link

Adding Swedish bankgiro recipients #40

Closed simplexab closed 2 years ago

simplexab commented 2 years ago

In Sweden it's common to transfer money to bankgiro numbers instead of IBAN, so my changes adds capability to output xml files compatible with SEB-bank and their expected bankgiro format. It depends on minor changes to SepaUtilities.

This is my first pull request ever, so be gentle. :)

simplexab commented 2 years ago

It was a while ago that I made the changes and I don't remember why I did some of them. Some changes might be completely unnecessary or outright bad for everyone else. I'm just trying to comply with the LGPL license.

AbcAeffchen commented 2 years ago

Thanks for the interest in Sephpa and for the effort to comply with LGPL. But I cannot merge your pull request for two reasons:

  1. The library is meant to handle SEPA transactions. At the time of writing the library I thought this is the same for every country, which turned out to be false and made this library already much more work to maintain than expected. I simply cannot maintain another system.
  2. Your changes actually break some parts of the library.

If you want to publish your changes and maintain bankgirot, I recommend creating an fork of Sephpa for that feature.

simplexab commented 2 years ago

I completely understand. Thanks for looking. :)