AbdElAziz333 / Canary

A performance mod designed to optimize Minecraft's general performance and unofficial fork of Lithium mod for Minecraft Forge.
https://www.curseforge.com/minecraft/mc-mods/canary
GNU Lesser General Public License v3.0
41 stars 3 forks source link

1.19.2 latest update crash with Create ponder #112

Closed CzarTheOwlman closed 1 year ago

CzarTheOwlman commented 1 year ago

Version

canary-mc1.19.2-0.1.9.jar

Reproduction Steps

Used Create's ponder feature on the portable storage interface, and halfway through the animation the game crashed

Crash Report File

crash-2023-03-06_15.40.48-client.txt

Additional Information

As far as I can see from the log, looks like there's a conflict with Canary's entity collision feature.

anarisis commented 1 year ago

Same issue. Pretty consistently reproduceable.

Crash report: https://bytebin.lucko.me/dMQOM9zrCj

DrUltraLux commented 1 year ago

Had the same issue yesterday also. Can confirm that rolling back to 0.1.8 solves the issue.

image

kawaiicakes commented 1 year ago

Getting this issue as well.

TheInfamousAlk commented 1 year ago

Me too! Using the Cottage Witch modpack. Only happens with some ponders like the saw, some are fine. crash-2023-03-21_22.09.01-client.txt

Urmus-dev commented 1 year ago

It also craches on 0.1.9 when looking at gantry moving. Going back to 0.1.8 solves it.

Branjoman commented 1 year ago

I'm seeing the same issue as well, and I think I've narrowed the issue down a bit as it doesn't affect every ponder. From my testing, any ponder that tries to put an item entity into it will crash (the chute ponder, for example), whereas ponders that don't are unaffected. Hopefully this new info will help towards fixing the core issue.

AbdElAziz333 commented 1 year ago

Fixed in my side, the release will updated soon.

ahmettcavus commented 1 year ago

can confirm also

DarkSolus commented 1 year ago

easily fixable by adding the following lines to canary.properties

mixin.entity.collisions=false mixin.entity.gravity_check_block_below=false

No idea which one fixes the bug, I decided better safe than sorry.

AbdElAziz333 commented 1 year ago

can you please use the new update? 1.19.4 - 1.19.3 - 1.19.2 - 1.18.2

shadow7483147 commented 1 year ago

can you please use the new update?

Yep! It no longer crashes, though some items are not visible while pondering. (Encased fan: gold ingot/nugget example; the tooltip icons still show up at least)

lynnpye commented 1 year ago

can you please use the new update?

Yep! It no longer crashes, though some items are not visible while pondering. (Encased fan: gold ingot/nugget example; the tooltip icons still show up at least)

Looks like the following setting allows the item to be visible again (specifically tested the encased fan scenario):

mixin.entity.collisions.movement=false