AbdElAziz333 / Canary

A performance mod designed to optimize Minecraft's general performance and unofficial fork of Lithium mod for Minecraft Forge.
https://www.curseforge.com/minecraft/mc-mods/canary
GNU Lesser General Public License v3.0
41 stars 3 forks source link

[1.19.2] Crashes with Inventorio #150

Closed No1129 closed 1 year ago

No1129 commented 1 year ago

Version

canary-mc1.19.2-0.2.3

Reproduction Steps

game crashes on boot when loaded with Inventorio

Crash Report File

https://file.garden/Yjp9XGA2LRQTk7Ha/latest.log https://file.garden/Yjp9XGA2LRQTk7Ha/debug.log

Additional Information

Inventorio mod link https://www.curseforge.com/minecraft/mc-mods/inventorio-forge

Reshy commented 1 year ago

It also happens on the 1.18.2 version. The developer of Inventorio said this:

https://github.com/Lizard-Of-Oz/Inventorio/issues/242#issuecomment-1573553078

Incompatibility with the Canary mod. Impossible to solve on my end, but the optimization Canary does at the point of mod conflict is by all means and purposes negligible, they could simply remove that mixin. It will solve the issue and have basically 0 impact. Alternatively, they could set that overwrite optional and set its priority lower than Inventorio's mixin here would have priority (we both went with exactly 1000, what a coincidence)

AbdElAziz333 commented 1 year ago

does it still happens in 0.2.4 versions in 1.19.x or in the 0.2.1 version of 1.18.2 of Canary?

Reshy commented 1 year ago

does it still happens in 0.2.4 versions in 1.19.x or in the 0.2.1 version of 1.18.2 of Canary?

I'll need to test, the issue isn't easy to replicate so it's hard to tell if I'm failing to replicate it or if the new version patched it.

AbdElAziz333 commented 1 year ago

Can you please try the new update, good luck!

laboriens commented 4 months ago

hello, the problem returned with canary-mc1.20.1-0.3.3