search

AbdelStark / token-vesting-contracts

ERC20 token vesting smart contracts 💰⏳
Apache License 2.0
193 stars 135 forks source link

Error with yarn test #35

Closed joelamouche closed 1 year ago

joelamouche commented 1 year ago

After running yarn, I get this error when running yarn test:

➜  token-vesting-contracts git:(main) ✗ yarn test
yarn run v1.22.10
$ npx hardhat test --logs
Error HH404: File lib/solmate/src/tokens/ERC20.sol, imported from src/TokenVesting.sol, not found.

For more info go to https://hardhat.org/HH404 or run Hardhat with --show-stack-traces
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
joelamouche commented 1 year ago

I have installed foundry and I am running v14.16.1

AbdelStark commented 1 year ago

After running yarn, I get this error when running yarn test:

➜  token-vesting-contracts git:(main) ✗ yarn test
yarn run v1.22.10
$ npx hardhat test --logs
Error HH404: File lib/solmate/src/tokens/ERC20.sol, imported from src/TokenVesting.sol, not found.

For more info go to https://hardhat.org/HH404 or run Hardhat with --show-stack-traces
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

the forge build command works for you ?

joelamouche commented 1 year ago

Sorry, I meant to say I did NOT install foundry 😖 Since the documentation implies that the repo can be used with hardhat without foundry. Trying with foundry now... The tests do work after running allthe foundry commands. Maybe you should specify it is necessary in the readme...

joelamouche commented 1 year ago

Unrelated question but have you thought of adding the feature of handling multiple beneficiaries by having a list of beneficiaries instead of one beneficiary?

AbdelStark commented 1 year ago

Sorry, I meant to say I did NOT install foundry 😖 Since the documentation implies that the repo can be used with hardhat without foundry. Trying with foundry now... The tests do work after running allthe foundry commands. Maybe you should specify it is necessary in the readme...

Oh ok. Yeah it should be more explicit indeed. Feel free to submit a PR if you want ;)

AbdelStark commented 1 year ago

Unrelated question but have you thought of adding the feature of handling multiple beneficiaries by having a list of beneficiaries instead of one beneficiary?

That's a good feature request. Can you please describe it in an issue ?

joelamouche commented 1 year ago

Sounds good I will make a PR and an issue later today

AbdelStark commented 1 year ago

Sounds good I will make a PR and an issue later today

awesome thanks