Ruby on Rails capstone project

[AbdelazizSoliman]

https://github.com/AbdelazizSoliman/Recipe_app/projects/1 We are 2 persons working on this project @AbdelazizSoliman @Peter-Dumbari

[Ibizugbe]

Hi @AbdelazizSoliman ,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted an issue, that doesn't have the right link to your github project.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

Invalid Code Review Request does not count into the code reviews limit.

[AbdelazizSoliman]

Hi @Ibizugbe, Udated

[Ibizugbe]

Hi @AbdelazizSoliman @Peter-Dumbari 👋🏼👋🏼👋🏼👋🏼,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights✅✅

• [ ] Issue has been updated with the link to the board👍🏼.
• [ ] The cards are descriptive👍🏼.

Required Changes ♻️

• [ ] Kindly ensure every card on the board has a point assigned to it and ensure the points are fairly distributed amongst team members👍🏼 currently, some of your cards don't have points assigned.
• [ ] Kindly ensure every requirements regarding to your team size, from the project requirements is captured and properly assigned in your project. some requirements are still not accounted for😉.

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[AbdelazizSoliman]

@Ibizugbe , I updated as required Every card on the board has a point assigned to it. I added the missed task "General shopping list view". Thank you.

[mukhammadrizooff]

Hi @TEAM,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights

• TEAM work✔️
• Correct GitFlow ✔️
• Good implementations ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.