[PATCH] Core support for ATmega1284P

[GoogleCodeExporter]

What change would like to see?

Support in the Arduino core for ATmega1284P

Why?

It is a very useful chip with 16k RAM and 128k flash.  The changes are very 
minimal, so having them in the main core means that we don't have to keep 
copying the official core to keep them in sync.

Would this cause any incompatibilities with previous versions?  If so, how
can these be mitigated?

No.  The changes are separated by the regular code using the existing standards 
for #ifdefs.  In one case a straight ifdef for ATmega1284P is needed, otherwise 
we can check for the existence of certain registers.

Original issue reported on code.google.com by maniac...@ymail.com on 24 Nov 2011 at 10:03

Attachments:

• 0001-Support-3rd-external-interrupt-on-1284P.patch
• 0002-Update-reference-voltage-defines-for-1284P.patch

[GoogleCodeExporter]

Looks reasonable.  We probably should push more of the CPU-specific 
configuration into the variants/ header files, but this seems like a reasonable 
approach in the meantime.

Original comment by dmel...@gmail.com on 26 Nov 2011 at 3:06

• Changed state: Accepted
• Added labels: Component-Core

[GoogleCodeExporter]

Great.  If you apply this, please also apply issue 727 OR let me submit an 
"#ifdef 1284P" version of 727 if you don't like how that patch approaches the 
problem.  Note that 727 exactly follows the model of pushing "more of the 
CPU-specific configuration into the variants/ header files".

Original comment by maniac...@ymail.com on 27 Nov 2011 at 6:21

[GoogleCodeExporter]

https://github.com/arduino/Arduino/commit/d7d0e304d53b8a75d61b1976ffe8a92d38e867
e2
https://github.com/arduino/Arduino/commit/eb380de9726d90d937f2d70d4b94bb60578316
c7

Original comment by dmel...@gmail.com on 2 Dec 2011 at 10:23

• Changed state: Fixed
• Added labels: Milestone-1.0.1