search

Abdeltwab / Flicker-App-MVVM

Flicker app clone Using MVVM + RXSwift
0 stars 0 forks source link

PhotoGalleryViewModel init #14

Closed knight6700 closed 3 years ago

knight6700 commented 3 years ago

why you pass PhotoGalleryContainerViewModelProtocol just passed fetchSearchResults why you passed all ?! it's a fat interface we can divide it to two interface to avoid interface aggregation

Abdo-codes commented 3 years ago

@knight6700 can you mention file name/line

knight6700 commented 3 years ago

PhotoGalleryViewModel()

Abdeltwab commented 3 years ago

The point was to prepare this for future passed parameters (when needed to pass more ) but your point is right , there are not related parameters that sent. I updated this here 4f6cb44dd0798b7e1478f963f705167cb4722cd3