search

AbdnBiomechEng / TechForParalysis

Aiming to improve arm function in people with high-level spinal injuries
https://gow.epsrc.ukri.org/NGBOViewGrant.aspx?GrantRef=EP/R035091/2
GNU General Public License v3.0
7 stars 3 forks source link

Increase optimality and feasibility tolerances of last iteration #7

Closed dblana closed 5 years ago

dblana commented 5 years ago

This is for runopt_elbow.m (lines 36 & 37)

RostiReadioff commented 5 years ago

I have changed the tolerance values on line 36&37 from 1e-5 to 1e-3 for both. In addition, I reduced max node number from 40 to 20. The optimisation run successfully and the simulation found optimal solutions.

dblana commented 5 years ago

Great, do you want to do a pull request so we can marge those changes into the master branch?

RostiReadioff commented 5 years ago

Pull request created. It is ready to be merged or declined. I also have the right to accept the pull request, but I leave that for you to manage.

dblana commented 5 years ago

Well done! :tada: I've left a comment about removing the opt_results folder, since these data files can be easily generated and there is no need to keep them under version control.

RostiReadioff commented 5 years ago

Not sure what the next step is, so I leave it as is for now and we can discuss next time we meet.