Abdo9826 / cars-bnb-backend

1 stars 2 forks source link

Final group capstone - Book an Appointment Kanban board #7

Open ksigei opened 1 year ago

ksigei commented 1 year ago

In this milestone, @bobb-Rob, @shahnawaza75, @ksigei and @Abdo9826 were able to:

Meltrust commented 1 year ago

Hi @ksigei

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that does not contain a note about the number of people in the team, and has no screenshot:

image

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready πŸ™

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Meltrust commented 1 year ago

Hi @ksigei,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

To highlight:

You can do it

Required Changes ♻️

Check the comments under the review.

Like this:

image

Feel free to use it.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘


Meltrust commented 1 year ago

Hi @ksigei,

Great work on making the changes requested by a previous reviewer πŸ‘ You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

You can do it

Required Changes ♻️

Check the comments under the review.

You can take another screenshot yourself, or use this one:

image

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


Meltrust commented 1 year ago

Hi @ksigei,,

Wow, you did it πŸŽ‰

Brilliant

Thank you for implementing the changes requested by the previous reviewer πŸ’ͺ πŸ₯‡ γŠ—οΈ

Well done!

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! πŸŽ‰

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.