AbdullahDaff / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Simplify #2

Open Tooconfident opened 7 years ago

Tooconfident commented 7 years ago

https://github.com/AbdullahDaff/prj-rev-bwfs-dasmoto/blob/master/Dasmato's%20Arts%20%26%20Craft%20Project/index.html#L10-L36

Great job using div containers to separate your sections. That's a good instinct. The placement of your divs can be simplified just a little bit, and it always a good idea to give any div you create a class or id because once you have so many of these containers without a custom selector, they are harder to track in your css.

https://gist.github.com/Tooconfident/21095a045d4a3828eb1c860200589917

By using div containers with the same class name since we see universal styling for all three sections, then you have an id on the <h2> since they have unique background colors. This will assist in cleaning things up in the css and preventing the need for too many general selectors.

AbdullahDaff commented 7 years ago

Thanks a lot, i will hopefully adjust on the comments of my usage of div.