AbdulrahmanAlRammah / pe

0 stars 0 forks source link

Not allowing uppercase prefixes #5

Open AbdulrahmanAlRammah opened 1 week ago

AbdulrahmanAlRammah commented 1 week ago

There is no reason for the prefixes to be case sensitive. The below test case (first screenshot) shows that have an uppercase n for the name prefix is not accepted when trying to add a new supplier.

The 2nd screenshot is to show that the input is accepted with lower case n for prefix.

image.png

image.png

nus-se-script commented 1 week ago

Team's Response

Thank you for reporting this issue. However, we do not think this is an important issue that affects most of our intended users because, as fast typer it is unlikely that they would capitalise their command prefixes or command words since that will only decrease their speed of typing and slow them down. Furthermore, we believe that adding this case insensitive commands is less important and takes less priority over the work that has been done already for our Application. Thus, this is NotInScope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: This bug falls under the 2nd bullet point below. Fixing this issue would just take adding one line to convert prefixes to lowercase in the prefix parsing (I did it for our project). Given its very low effort it could have been done by the team. Even as a fast typist it possible to forget caps lock on or accidentally click shift. There is no need to limit the prefixes to being only lowercase and this is a low effort change so I would argue it shouldn't be classified out of scope.

image.png