Final Project Feedback: Great job!

[ConsenSys-Academy]

Great job @AbdulrazakZakieh ! We'll be approving it on the course itself in a week or two, but here's your feedback in the meanwhile:

Frontend

• Frontend looks great! Like the detection of MetaMask
• One note: It's not clear which network the user needs to be on (Rinkeby), perhaps you could have either a chainID detection or even something as simple as text saying ""Please switch to Rinkeby"" if it doesn't detect Rinkeby network
• One issue, 2ETH is quite a bit (even on Rinkeby!) might be better to create a lower threshold. Making me burn 2ETH is painful!!
• Also, might be good to save the contract address somewhere on the frontend so the user can upload it easier in the Management section

Testing

• Great use of the basic protection here for your smart contract, such as specific compiler. Would be good to have some more specific security features introduced that help with your specific contract
• Some issues running npm install -- might want to have someone else run it -- it also needs to be in your instructions under "Testing"

Design and Security

• Great use of the basic protection here for your smart contract, such as specific compiler. Would be good to have some more specific security features introduced that help with your specific contract
• I don't think you have to do the Owned inheritance here since the implementation is simple, typically inheritance would involve a much larger contract. But it's good to have some inheritance!
• Nice build-out of features here, was the contract particularly expensive to deploy? Seems like a lot of variables!

Additional Comments

• Great use of IPFS, really awesome you were able to incorporate hitting the endpoint of an IPFS node while also uploading the hash to an Ethereum smart contract. Complicated, and you did an awesome job implementing it.

• Overall, great job Abdul! A couple things to consider: minimizing the ""surface area"" of the contract -- there is a lot of code here, it might be better to try to consolidate and make things a bit tighter -- the more code you have the greater the likelihood of weaknesses / bugs / exploits

• Also, try having a friend run the tests locally to see the issues we mentioned.

• Fantastic job on the project though and meeting the requirements in the desired time!

[AbdulrazakZakieh]

Thank you for the great course and for your feedback as well. It was challenging to do the project while working and studying at the same time. Do I have to do the changes you mentioned to pass the course? For 2 Eth, I thought that there should be a minimal guarantee to make sure judges are compensated for their attributions. You are right, I should have put the network used and make the contract id on page through multiple pages. For the deployment fees, it was 0.00907 Eth. Thanks for appreciation and thanks again for taking time in assessing the project.