Abe404 / RootPainter3D

RootPainter3D: Interactive-machine-learning enables rapid and accurate contouring for radiotherapy
GNU General Public License v3.0
19 stars 10 forks source link

Icon fix windows #15

Closed andreped closed 2 years ago

andreped commented 2 years ago

After installing the software through the binary installer on Windows, you will find that the icon is not showing.

However, if you restart the machine, the icon will show.

This is because during installation, we are creating the shortcuts before the icons are written to disk, which means that the icons are not available.

However, when restarting, Windows will refetch the icons, which is why the icon now will show.

The fix was basically to change the installation order in the .nsi file. Quite easy to do, but was challenging to debug. However, I found the same issue in a related software, Raidionics.

I also found that setting the icons for the shortcut is not necessary, as modern NSIS will find the correct icon dynamically by using the icon of the executable.